diff --git a/src/widgets/styles/qdrawutil.cpp b/src/widgets/styles/qdrawutil.cpp index 5bdbdb11395..192ea6d25c5 100644 --- a/src/widgets/styles/qdrawutil.cpp +++ b/src/widgets/styles/qdrawutil.cpp @@ -572,18 +572,19 @@ void qDrawWinPanel(QPainter *p, int x, int y, int w, int h, */ void qDrawPlainRect(QPainter *p, int x, int y, int w, int h, const QColor &c, - int lineWidth, const QBrush *fill) + int lineWidth, const QBrush *fill) { if (w == 0 || h == 0) return; if (Q_UNLIKELY(w < 0 || h < 0 || lineWidth < 0)) { qWarning("qDrawPlainRect: Invalid parameters"); + return; } PainterStateGuard painterGuard(p); + painterGuard.save(); const qreal devicePixelRatio = p->device()->devicePixelRatio(); if (!qFuzzyCompare(devicePixelRatio, qreal(1))) { - painterGuard.save(); const qreal inverseScale = qreal(1) / devicePixelRatio; p->scale(inverseScale, inverseScale); x = qRound(devicePixelRatio * x); @@ -594,8 +595,6 @@ void qDrawPlainRect(QPainter *p, int x, int y, int w, int h, const QColor &c, p->translate(0.5, 0.5); } - QPen oldPen = p->pen(); - QBrush oldBrush = p->brush(); p->setPen(c); p->setBrush(Qt::NoBrush); for (int i=0; isetBrush(*fill); p->drawRect(x+lineWidth, y+lineWidth, w-lineWidth*2, h-lineWidth*2); } - p->setPen(oldPen); - p->setBrush(oldBrush); } /*! @@ -638,19 +635,20 @@ void qDrawPlainRect(QPainter *p, int x, int y, int w, int h, const QColor &c, // ### Qt7: Pass QPen instead of QColor for frame drawing void qDrawPlainRoundedRect(QPainter *p, int x, int y, int w, int h, - qreal rx, qreal ry, const QColor &c, - int lineWidth, const QBrush *fill) + qreal rx, qreal ry, const QColor &c, + int lineWidth, const QBrush *fill) { if (w == 0 || h == 0) return; if (Q_UNLIKELY(w < 0 || h < 0 || lineWidth < 0)) { qWarning("qDrawPlainRect: Invalid parameters"); + return; } PainterStateGuard painterGuard(p); + painterGuard.save(); const qreal devicePixelRatio = p->device()->devicePixelRatio(); if (!qFuzzyCompare(devicePixelRatio, qreal(1))) { - painterGuard.save(); const qreal inverseScale = qreal(1) / devicePixelRatio; p->scale(inverseScale, inverseScale); x = qRound(devicePixelRatio * x); @@ -661,7 +659,6 @@ void qDrawPlainRoundedRect(QPainter *p, int x, int y, int w, int h, p->translate(0.5, 0.5); } - p->save(); p->setPen(c); p->setBrush(Qt::NoBrush); for (int i=0; isetBrush(*fill); p->drawRoundedRect(x+lineWidth, y+lineWidth, w-lineWidth*2, h-lineWidth*2, rx, ry); } - p->restore(); } /*****************************************************************************