Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty menu item title messes up menu structure #255

Closed
herrvigg opened this issue Jun 22, 2018 · 4 comments
Closed

Empty menu item title messes up menu structure #255

herrvigg opened this issue Jun 22, 2018 · 4 comments
Labels
enhancement New feature or request legacy issue Legacy issue imported from original repo

Comments

@herrvigg
Copy link
Collaborator

Issue by cdauth
Friday Sep 11, 2015 at 13:25 GMT
Originally opened as qTranslate-Team/qtranslate-x#255


In qtranslate_frontend.php, menu items with an empty title are removed from the menu. Any sub-items of the item that is removed are not removed from the menu. This will cause Wordpress to display them as top-level menu items.

For example, create a menu like this:

- Test
- (Empty title)
    - Sub item 1
    - Sub item 2
- Test 2

It will be displayed like this:

- Test
- Sub item 1
- Sub item 2
- Test 2

If a menu item is removed, the sub-items should be removed too.

@herrvigg herrvigg added enhancement New feature or request legacy issue Legacy issue imported from original repo labels Jun 22, 2018
@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Friday Sep 11, 2015 at 17:49 GMT


Good point, thank you for the report. Is there any chance you would submit a pull request with a code to fix it?

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Monday Sep 14, 2015 at 03:02 GMT


The fix will be in release 3.4.5, it is now on GitHub. Do you have a quick way to test it? Please, let me know if there is a problem.

@herrvigg
Copy link
Collaborator Author

Comment by ouiliam
Sunday Aug 13, 2017 at 04:39 GMT


this is still a problem on release 3.4.6.8 WP 4.8.1
add an empty custom menu item with # as URL (to be used as a submenu group title), and the order is messed up and changes to EN menu items are no longer properly mirrored in other languages.

when custom links are used, the custom link URL gets modified by qtranslate.

@herrvigg
Copy link
Collaborator Author

Comment by ouiliam
Sunday Aug 13, 2017 at 05:34 GMT


I found in your FAQ the solution to the custom link issue (&setlang=no) but the empty custom link menu items issue still remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request legacy issue Legacy issue imported from original repo
Projects
None yet
Development

No branches or pull requests

1 participant