Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch BundleGenerationConfiguration to ConfigMapping #920

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

metacosm
Copy link
Member

Signed-off-by: Chris Laprun claprun@redhat.com

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm self-assigned this Aug 12, 2024
@metacosm metacosm requested a review from gsmet August 12, 2024 10:37
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted an issue. Not sure if it's going to fix your problem.

Also if you're not always generating a BuildItem that will match, you need to inject it with Optional<YourBuildItem>.

Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com>
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm requested a review from gsmet August 12, 2024 15:29
@metacosm metacosm merged commit 2095958 into main Aug 12, 2024
6 checks passed
@metacosm metacosm deleted the finish-configmapping branch August 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants