Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows CI build Mandrel version? #36499

Closed
gsmet opened this issue Oct 16, 2023 · 5 comments
Closed

Update Windows CI build Mandrel version? #36499

gsmet opened this issue Oct 16, 2023 · 5 comments
Assignees
Labels
area/mandrel env/windows Impacts Windows machines

Comments

@gsmet
Copy link
Member

gsmet commented Oct 16, 2023

Our Windows CI build is still using Mandrel for Java 17 AFAIK:

      - name: Setup GraalVM
        id: setup-graalvm
        uses: graalvm/setup-graalvm@v1
        if: startsWith(matrix.os-name, 'windows')
        with:
          version: 'mandrel-latest'
          java-version: '17'
          components: 'native-image'
          github-token: ${{ secrets.GITHUB_TOKEN }}

See https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-actions-incremental.yml#L905-L913

I have also seen some 404 failures when the action is run so I'm wondering if it needs further adjustments?

Also, I think I had some issues with this in old branches as I couldn't find a way to use graalvm/setup-graalvm@v1 and point to the older Mandrel version we wanted to use.

Maybe the Mandrel team already solved this and can help?

@quarkus-bot quarkus-bot bot added area/mandrel env/windows Impacts Windows machines labels Oct 16, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 16, 2023

/cc @Karm (mandrel), @galderz (mandrel), @zakkak (mandrel)

@zakkak
Copy link
Contributor

zakkak commented Oct 16, 2023

I have also seen some 404 failures when the action is run so I'm wondering if it needs further adjustments?

If not persistent it could be some GH network issue, AFAIK the action just downloads the releases from github and installs them in the GH runner instance.

Also, I think I had some issues with this in old branches as I couldn't find a way to use graalvm/setup-graalvm@v1 and point to the older Mandrel version we wanted to use.

Maybe the Mandrel team already solved this and can help?

Sure, I will have a look.

@zakkak zakkak self-assigned this Oct 16, 2023
@zakkak
Copy link
Contributor

zakkak commented Oct 17, 2023

I have also seen some 404 failures when the action is run so I'm wondering if it needs further adjustments?

Tracked in setup-graalvm repository: graalvm/setup-graalvm#64

Also, I think I had some issues with this in old branches as I couldn't find a way to use graalvm/setup-graalvm@v1 and point to the older Mandrel version we wanted to use.

Yes, that's because we use mandrel-latest, so 3.2 which should be using Mandrel 23.0 tries to fetch 23.1... When creating a release branch we should switch from mandrel-latest to the actual version we are interested in. One issue with this is that we can't (at the moment) say version: 23.0 and have setup-graalvm fetch the latest 23.0.x release, at the moment we need to use the exact version, e.g. mandrel-23.0.1.2-Final.

@gsmet
Copy link
Member Author

gsmet commented Nov 25, 2023

This has been somehow sorted out by @zakkak so we can close this one. If it needs further refinements, we probably need a new issue with a better title.

@gsmet gsmet closed this as completed Nov 25, 2023
@zakkak
Copy link
Contributor

zakkak commented Nov 27, 2023

FTR this was fixed in graalvm/setup-graalvm#67

We still can't define version as 23.0 and have setup-graalvm fetch the latest 23.0.x release, but at least we can use mandrel-latest and set the java-version to get the latest mandrel build based on that java-version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mandrel env/windows Impacts Windows machines
Projects
None yet
Development

No branches or pull requests

2 participants