Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraalVM Version parser is too strict #36972

Closed
brunocaballero opened this issue Nov 9, 2023 · 4 comments
Closed

GraalVM Version parser is too strict #36972

brunocaballero opened this issue Nov 9, 2023 · 4 comments
Assignees
Labels

Comments

@brunocaballero
Copy link
Contributor

brunocaballero commented Nov 9, 2023

Describe the bug

When building a Native Image using GraalVM, Quarkus parses the version of native-image on the following class:

https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/GraalVM.java

The check fails for some custom Runtimes we are developing.

In particular Quarkus expects the runtime to be OpenJDK or GraalVM, and the vm name OpenJDK 64-Bit Server or Substrate

private static final String RUNTIME_NAME = "(?<RUNTIME>(?:OpenJDK|GraalVM) Runtime Environment) ";
private static final String VM_NAME = "(?<VM>(?:OpenJDK 64-Bit Server|Substrate) VM) ";

Expected behavior

I would expect to accept other runtimes.

Maybe something like:

private static final String RUNTIME_NAME = "(?<RUNTIME>.*) Runtime Environment) ";
private static final String VM_NAME = "(?<VM>.*) VM) ";

Actual behavior

Other runtimes are currently not supported by recent version of Quarkus.

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Mandrel or GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

Copy link

quarkus-bot bot commented Nov 9, 2023

/cc @Karm (mandrel), @galderz (mandrel), @zakkak (mandrel)

@zakkak
Copy link
Contributor

zakkak commented Nov 9, 2023

Hi @brunocaballero, that makes sense.

Could you please open a PR with the necessary changes, extending the tests in https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/test/java/io/quarkus/deployment/pkg/steps/GraalVMTest.java to cover your case as well?

cc @jerboaa

@jerboaa
Copy link
Contributor

jerboaa commented Dec 15, 2023

I think that one got fixed with #37651?

@brunocaballero
Copy link
Contributor Author

yes, fixed in #37651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants