-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configproperty value containing '$$' will be '$' as string #41883
Comments
/cc @radcortez (config) |
The property expression syntax uses |
We do We probably shouldn't be making the |
@radcortez thanks for your reply. Exactly that's what I expect. I would like to be able to use the raw value: Use a secret holding a key, in this case containing |
This would cause yet another grammatical ambiguity that could be very hard to untangle. If there is a curly brace right after |
Correct. but that is not currently the case. A value like (we don't have that flag on btw) |
The reason is just that this has historically been the escape for |
What if? # old
${foo} -> expand
$${foo} -> ${foo}
$$ -> $
# new
${foo} -> expand
$${foo} -> ${foo}
$$ -> $$ |
Hmm I believe it should be: # old
${foo} -> expand
$${foo} -> ${foo}
$$ -> $
# new
${foo} -> expand
$${foo} -> $expand
$$ -> $$ There should just be a check for |
You still want to be able to provide an escape to not expand, and have a |
This causes complexity in the grammar because now The solution to a syntax inconvenience is almost never to patch the syntax, unless you have examined the syntax description (the original BNF or the DFA) and can show that the change does not introduce an ambiguity. |
Describe the bug
When injecting a configproperty, containing '$$' , the string value will contain just one dollarsign: '$' See my attached reproducer. I've not found any other special character with this behavior. Is this expected behavior, from the microprofile spec which I've found or is this a bug?
Run the tests and see the one which is failing for a reproducer.
Expected behavior
I would like to be able to use the correct value of a configproperty with a value containing: '$$'
Actual behavior
The value of a configproperty with a value containing: '$$' is changed to: '$'
How to Reproduce?
Run the test in: https://github.com/appiepollo14/quarkus-reproducer/tree/configproperty
and see the following diff:
Output of
uname -a
orver
Darwin MacBook-Pro.local 23.5.0 Darwin Kernel Version 23.5.0: Wed May 1 20:12:58 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6000 arm64
Output of
java -version
openjdk version "21.0.2" 2024-01-16
Quarkus version or git rev
3.12.2
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
Additional information
It doesn't matter whether the value is set via an environment variable or for example in the applications.properties file
The text was updated successfully, but these errors were encountered: