Register JBoss EnhancedQueueExecutor$RuntimeFields for runtime init #43798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakkak
added a commit
to zakkak/jboss-threads
that referenced
this pull request
Oct 10, 2024
See https://www.graalvm.org/jdk21/reference-manual/native-image/overview/BuildConfiguration/#embed-a-configuration-file This way consumers of the maven artifact won't need to manually register the said class for runtime initialization (i.e. quarkusio/quarkus#43798 and similar PRs become redundant)
gsmet
reviewed
Oct 10, 2024
core/deployment/src/main/java/io/quarkus/deployment/JBossProcessor.java
Outdated
Show resolved
Hide resolved
|
Speaking of which, can't https://github.com/jbossas/jboss-threads provide its own
|
zakkak
added a commit
to zakkak/jboss-threads
that referenced
this pull request
Oct 10, 2024
See https://www.graalvm.org/jdk21/reference-manual/native-image/overview/BuildConfiguration/#embed-a-configuration-file This way consumers of the maven artifact won't need to manually register the said class for runtime initialization (i.e. quarkusio/quarkus#43798 and similar PRs become redundant)
This comment has been minimized.
This comment has been minimized.
zakkak
added a commit
to zakkak/jboss-threads
that referenced
this pull request
Oct 10, 2024
See https://www.graalvm.org/jdk21/reference-manual/native-image/overview/BuildConfiguration/#embed-a-configuration-file This way consumers of the maven artifact won't need to manually register the said class for runtime initialization (i.e. quarkusio/quarkus#43798 and similar PRs become redundant)
zakkak
force-pushed
the
2024-10-10-fix-43797
branch
from
af0f05c to
aab9355
Compare
dmlloyd
approved these changes
Oct 10, 2024
gastaldi
approved these changes
Oct 10, 2024
gastaldi
added
the
triage/waiting-for-ci
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in the source code
https://github.com/jbossas/jboss-threads/blob/60a6d35ec56e85f683ff45d89b29ea4f7b0e01aa/src/main/java/org/jboss/threads/EnhancedQueueExecutor.java#L325
Closes #43797