Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad9959 little things #172

Closed
jordens opened this issue Nov 17, 2020 · 0 comments · Fixed by #186
Closed

ad9959 little things #172

jordens opened this issue Nov 17, 2020 · 0 comments · Fixed by #186

Comments

@jordens
Copy link
Member

jordens commented Nov 17, 2020

ad9959.io_update.set_low().or_else(|_| Err(Error::Pin))?;

Can be or(Err(Error::Pin)) It hink (also other places).

.delay_ms((1000.0 / clock_frequency as f32) as u8);

Is delay_ms(0) and can become delay_us(1u8) everywhere. reference_clock >= 1 MHz always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant