Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling fallback to non domain remote calls #96

Merged
merged 1 commit into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/fastrpc_apps_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ int fastrpc_set_remote_uthread_params(int domain) {
if ((handle = get_remotectl1_handle(domain)) != INVALID_HANDLE) {
nErr = remotectl1_set_param(handle, th_params->reqID, (uint32_t *)th_params,
paramsLen);
if (nErr == DSP_AEE_EOFFSET + AEE_ENOSUCHMOD) {
if (nErr == DSP_AEE_EOFFSET + AEE_ERPC) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AEE_ERPC can be returned for multiple reasons. Need to make it more accurate.

FARF(ALWAYS,
"Warning 0x%x: %s: remotectl1 domains not supported for domain %d\n",
nErr, __func__, domain);
Expand Down Expand Up @@ -1676,7 +1676,7 @@ int remote_handle_open_domain(int domain, const char *name, remote_handle *ph,
if ((handle = get_remotectl1_handle(domain)) != INVALID_HANDLE) {
nErr = remotectl1_open1(handle, name, (int *)ph, dlerrstr,
sizeof(dlerrstr), &dlerr);
if (nErr == DSP_AEE_EOFFSET + AEE_ENOSUCHMOD) {
if (nErr == DSP_AEE_EOFFSET + AEE_ERPC) {
FARF(ALWAYS,
"Warning 0x%x: %s: remotectl1 domains not supported for domain "
"%d\n",
Expand Down Expand Up @@ -1827,7 +1827,7 @@ int remote_handle_close_domain(int domain, remote_handle h) {
&t_close,
if ((handle = get_remotectl1_handle(domain)) != INVALID_HANDLE) {
nErr = remotectl1_close1(handle, h, dlerrstr, err_str_len, &dlerr);
if (nErr == DSP_AEE_EOFFSET + AEE_ENOSUCHMOD) {
if (nErr == DSP_AEE_EOFFSET + AEE_ERPC) {
FARF(ALWAYS,
"Warning 0x%x: %s: remotectl1 domains not supported for domain "
"%d\n",
Expand Down Expand Up @@ -1967,7 +1967,7 @@ static int manage_adaptive_qos(int domain, uint32_t enable) {
*/
if ((handle = get_remotectl1_handle(domain)) != INVALID_HANDLE) {
nErr = remotectl1_set_param(handle, RPC_ADAPTIVE_QOS, &enable, 1);
if (nErr == DSP_AEE_EOFFSET + AEE_ENOSUCHMOD) {
if (nErr == DSP_AEE_EOFFSET + AEE_ERPC) {
FARF(ALWAYS,
"Warning 0x%x: %s: remotectl1 domains not supported for domain "
"%d\n",
Expand Down
2 changes: 1 addition & 1 deletion src/listener_android.c
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ static void *listener_start_thread(void *arg) {
set_thread_context(domain);
if ((adsp_listener1_handle = get_adsp_listener1_handle(domain)) != INVALID_HANDLE) {
nErr = __QAIC_HEADER(adsp_listener1_init2)(adsp_listener1_handle);
if (nErr == DSP_AEE_EOFFSET + AEE_ENOSUCHMOD) {
if (nErr == DSP_AEE_EOFFSET + AEE_ERPC) {
FARF(ERROR, "Error 0x%x: %s domains support not available in listener",
nErr, __func__);
fastrpc_update_module_list(DOMAIN_LIST_DEQUEUE, domain, _const_adsp_listener1_handle, NULL, NULL);
Expand Down
Loading