Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/interchainstaking/keeper: consider replacing duplicate ibc-go verification code #186

Open
elias-orijtech opened this issue Aug 25, 2022 · 3 comments
Open

x/interchainstaking/keeper: consider replacing duplicate ibc-go verification code #186

elias-orijtech opened this issue Aug 25, 2022 · 3 comments
Labels
module: interchainstaking

Comments

@elias-orijtech
Copy link
Contributor

As described in the comment,

https://github.com/ingenuity-build/quicksilver/blob/a7f142ab99e978482f66248d0009b90820d0f0ce/x/interchainstaking/keeper/callbacks.go#L384-L386

there is an unfortunate duplication of the ClientKeeper.CheckHeaderAndUpdateState method. It seems to me cosmos/ibc-go#1208 voids the reason for duplication and that theVerifyClientMessage/CheckForMisbehaviour methods can be used as replacement.

CC @odeke-em
@joe-bowman
Copy link
Contributor

This requires an update to ibc-go v5; which has other dependencies.

@joe-bowman
Copy link
Contributor

This actually requires ibc v6, not v5

@joe-bowman
Copy link
Contributor

#358 adds ibc v6, so we should be able to resolve this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: interchainstaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joe-bowman @elias-orijtech