Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforcing "NOT" and "-" queries consistency in UserInputAst #1609

Merged
merged 2 commits into from
May 12, 2023
Merged

Enforcing "NOT" and "-" queries consistency in UserInputAst #1609

merged 2 commits into from
May 12, 2023

Conversation

bazhenov
Copy link
Contributor

@bazhenov bazhenov commented Oct 9, 2022

One additional phase added to parse_to_ast() (rewrite_ast()) which removes unnecessary nesting of clauses in UserInputAst::Clause

Motivated by #1433

@bazhenov bazhenov mentioned this pull request Oct 9, 2022
Closed
adamreichold
adamreichold reviewed Oct 9, 2022
View reviewed changes
query-grammar/src/query_grammar.rs Outdated Show resolved Hide resolved
query-grammar/src/query_grammar.rs Outdated Show resolved Hide resolved
@bazhenov bazhenov force-pushed the issue-1433 branch 2 times, most recently from 79fe8aa to 88fe5cc Compare October 9, 2022 08:13
adamreichold
adamreichold approved these changes Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it means anything coming from a bystander, but I like the change as presented now.

@fulmicoton
Copy link
Collaborator

@bazhenov @adamreichold Apologies for not merging this earlier. Thank you for the ocntirbution.

@fulmicoton fulmicoton merged commit e248a49 into quickwit-oss:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bazhenov @fulmicoton @adamreichold