fix doc store cache docs #1821
Merged
fix doc store cache docs #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses an issue reported in #1820
Codecov Report
@@ Coverage Diff @@
## main #1821 +/- ##
==========================================
- Coverage 93.63% 93.62% -0.01%
==========================================
Files 314 314
Lines 57099 57102 +3
==========================================
- Hits 53466 53464 -2
- Misses 3633 3638 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
reviewed
Jan 23, 2023
src/reader/mod.rs
Outdated
| @@ -178,7 +178,7 @@ impl InnerIndexReader { | |||
| &searcher_generation_inventory, | |||
| )?; | |||
| Ok(InnerIndexReader { | |||
| doc_store_cache_size, | |||
| doc_store_cache_num_blocks: doc_store_cache_size, | |||
There was a problem hiding this comment.
we need to rename the argument too.
fulmicoton
approved these changes
Jan 23, 2023
Hodkinson
pushed a commit
to Hodkinson/tantivy
that referenced
this pull request
Jan 30, 2023
* fix doc store cache docs addresses an issue reported in quickwit-oss#1820 * rename doc_store_cache_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses an issue reported in #1820