-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix doc store cache docs #1821
fix doc store cache docs #1821
Conversation
addresses an issue reported in #1820
Codecov Report
@@ Coverage Diff @@
## main #1821 +/- ##
==========================================
- Coverage 93.63% 93.62% -0.01%
==========================================
Files 314 314
Lines 57099 57102 +3
==========================================
- Hits 53466 53464 -2
- Misses 3633 3638 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
src/reader/mod.rs
Outdated
@@ -178,7 +178,7 @@ impl InnerIndexReader { | |||
&searcher_generation_inventory, | |||
)?; | |||
Ok(InnerIndexReader { | |||
doc_store_cache_size, | |||
doc_store_cache_num_blocks: doc_store_cache_size, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to rename the argument too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for following up on this. Can you rename the arguemtn as mentionned in my comment?
* fix doc store cache docs addresses an issue reported in quickwit-oss#1820 * rename doc_store_cache_size
addresses an issue reported in #1820