Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate index record option, instead of vint error #1857

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: validate index record option, instead of vint error #1857

merged 1 commit into from
Feb 10, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Feb 10, 2023 •
edited
Loading

Prev:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IoError(Custom { kind: InvalidData, error: "Reach end of buffer while reading VInt" })', src/main.rs:46:14

Now:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: SchemaError("Received invalid index record option: WithFreqsAndPositions, Actual: Basic. Field \"source\"")', src/main.rs:46:14

fulmicoton
fulmicoton reviewed Feb 10, 2023
View reviewed changes
src/query/term_query/term_query.rs Outdated
Ok(TermWeight::new(
self.term.clone(),
index_record_option,
acutal_index_record_option,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
acutal_index_record_option,
actual_index_record_option,

@PSeitz PSeitz force-pushed the check_index_rec branch 5 times, most recently from bccb87e to db349e3 Compare February 10, 2023 12:34
@PSeitz
fix: auto downgrade index record option, instead of vint error
a06d0b7 
Prev: thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IoError(Custom { kind: InvalidData, error: "Reach end of buffer while reading VInt" })', src/main.rs:46:14
Now: Automatic downgrade to next available level
@PSeitz PSeitz merged commit 36c6138 into main Feb 10, 2023
@PSeitz PSeitz deleted the check_index_rec branch February 10, 2023 12:45
fulmicoton pushed a commit that referenced this pull request Mar 13, 2023
@PSeitz @fulmicoton
fix: auto downgrade index record option, instead of vint error (#1857)
7bf0a14 
Prev: thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IoError(Custom { kind: InvalidData, error: "Reach end of buffer while reading VInt" })', src/main.rs:46:14
Now: Automatic downgrade to next available level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PSeitz @fulmicoton