Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing parameter for stats,min,max,count,sum,avg #2151

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Aug 25, 2023

add missing parameter for stats,min,max,count,sum,avg #1789
add tests for #1913

@PSeitz PSeitz requested a review from fulmicoton August 25, 2023 07:38
add missing parameter for stats,min,max,count,sum,avg
closes #1913
partially #1789
Co-authored-by: Paul Masurel <paul@quickwit.io>
@PSeitz PSeitz merged commit 73cb717 into main Aug 28, 2023
5 checks passed
@PSeitz PSeitz deleted the test_missing_column branch August 28, 2023 06:59
ethever pushed a commit to ethever/tantivy that referenced this pull request Aug 30, 2023
)

* add missing parameter for stats,min,max,count,sum,avg

add missing parameter for stats,min,max,count,sum,avg
closes quickwit-oss#1913
partially quickwit-oss#1789

* Apply suggestions from code review

Co-authored-by: Paul Masurel <paul@quickwit.io>

---------

Co-authored-by: Paul Masurel <paul@quickwit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants