add missing parameter for stats,min,max,count,sum,avg #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
test_missing_column
branch
from
abfdefa
to
cb27d77
Compare
fulmicoton
reviewed
Aug 27, 2023
fulmicoton
reviewed
Aug 27, 2023
fulmicoton
reviewed
Aug 27, 2023
fulmicoton
reviewed
Aug 27, 2023
fulmicoton
reviewed
Aug 27, 2023
fulmicoton
reviewed
Aug 27, 2023
fulmicoton
approved these changes
Aug 27, 2023
Co-authored-by: Paul Masurel <paul@quickwit.io>
ethever
pushed a commit
to ethever/tantivy
that referenced
this pull request
Aug 30, 2023
) * add missing parameter for stats,min,max,count,sum,avg add missing parameter for stats,min,max,count,sum,avg closes quickwit-oss#1913 partially quickwit-oss#1789 * Apply suggestions from code review Co-authored-by: Paul Masurel <paul@quickwit.io> --------- Co-authored-by: Paul Masurel <paul@quickwit.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing parameter for stats,min,max,count,sum,avg #1789
add tests for #1913