Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for "reached the type-length limit" in interop crate #839

Closed
djc opened this issue Aug 23, 2020 · 3 comments
Closed

Tracking issue for "reached the type-length limit" in interop crate #839

djc opened this issue Aug 23, 2020 · 3 comments

Comments

@djc
Copy link
Member

djc commented Aug 23, 2020

This seems to be an instance of rust-lang/rust#54540 which apparently has gotten worse due to rust-lang/rust#75443 (which has been on nightly since 2020-08-14 and is now also a part of 1.46.0-beta.5. There seems to be an interaction with tracing, described in tokio-rs/tracing#616.

First noticed in CI, for example https://github.com/djc/quinn/pull/837/checks?check_run_id=1017422950.

@Ralith
Copy link
Collaborator

Ralith commented Aug 23, 2020

The error appears to reference this code:

    let results = future::join_all(peers.into_iter().map(|peer| async move {
        let span = info_span!("peer", name = peer.name.as_str());
        let result = run(&peer, keylog).instrument(span).await;
        (peer, result)
    }));

Maybe info_span! is expanding to something wildly complex? Can't otherwise see how this would have anything to do with tracing (or indeed be an issue at all).

@tmandry
Copy link

tmandry commented Sep 4, 2020

cc rust-lang/rust#64496

@djc
Copy link
Member Author

djc commented Sep 11, 2020

Fixed (well, worked around) in #844.

@djc djc closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants