Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Surah page needs to be refreshed for custom options to apply #550

Closed
umairidris opened this issue Dec 30, 2016 · 2 comments
Closed

Surah page needs to be refreshed for custom options to apply #550

umairidris opened this issue Dec 30, 2016 · 2 comments

Comments

@umairidris
Copy link
Contributor

umairidris commented Dec 30, 2016

I am hitting a bug where my options (such as reciters, translations, reading mode, etc) get reset (when going to a surah from the quran.com homepage) and need to be refreshed. Sometimes a change in setting needs a refresh too in order to be applied.

Steps to reproduce:

  • Go to quran.com
  • Click on surah 1 (Al-Fatihah)
  • Change the reciter, translations and/or reading mode from the default setting
  • Note: Refreshing the page or going to quran.com/1 or a diffrent surah (e.g. quran.com/2) in a new tab will keep the correct settings
  • Go to quran.com
  • Click on surah 1 (Al-Fatihah)
  • Note: the settings change back to default and require a refresh

Additional Info:

  • Browser: Chrome 55.0.2883.103 (64-bit)
  • Laptop: Toshiba Chromebook 2 (2014)
  • OS: Chrome OS

If this is a legitimate bug I can try to tackle it when I get a chance.

@umairidris umairidris changed the title Options get reset when going from homepage Options get reset when going to ayah from homepage Dec 30, 2016
@umairidris umairidris changed the title Options get reset when going to ayah from homepage Options get reset when going to surah from homepage Dec 30, 2016
@umairidris umairidris changed the title Options get reset when going to surah from homepage Surah page needs to be refreshed for custom options to apply Jan 1, 2017
@SanPilot
Copy link

SanPilot commented Jan 2, 2017

I've dug around a little - I don't know the cause but can help.

The settings are stored in a cookie named 'options'. When I change the Reciter, for example, the cookie, which is URL encoded JSON, changes to my new setting (in this case, the "audio" property changes).

Strangely, when I go from quran.com/1 to the homepage and back to quran.com/1, the cookie remains but the setting is not applied. The issue seems to be that the page is ignoring the cookie.

This behavior is particularly curious since, like OP said, navigating to a different Surah does not cause the issue.

@mmahalwy
Copy link
Contributor

mmahalwy commented Jan 5, 2017

@umairidris @SanPilot thanks for looking into this issue. Might be great to centralize the options into one place and add this feature request: #552

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants