Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments after meaningful statements in QASM reader #218

Merged
merged 10 commits into from
Oct 8, 2023
Merged

Remove comments after meaningful statements in QASM reader #218

merged 10 commits into from
Oct 8, 2023

Conversation

NoriyukiK-1qbit
Copy link
Contributor

QASMBench has lines that have comments after instructions, and those lines cause errors. This fix remove such comments.

@NoriyukiK-1qbit
QASMBench has comments after instructions
3914ca9 
QASMBench has lines that have comments after instructions, and those lines cause errors.
This fix remove such comments.
@NoriyukiK-1qbit
Update qasm.py to follow PEP8
06d5bd2
@BoxiLi
Copy link
Member

BoxiLi commented Sep 27, 2023

Thank you! Could you add a test to test_qasm.py and verify that it works after adding these lines?

@NoriyukiK-1qbit
Copy link
Contributor Author

Hi BoxiLi,
Thanks for your comment. I added the test, and it worked as expected. Please find added files.
NK

BoxiLi
BoxiLi requested changes Sep 30, 2023
View reviewed changes
Copy link
Member

@BoxiLi BoxiLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good! I left a comment with a minor change in the test file.

tests/test_qasm.py Outdated Show resolved Hide resolved
@NoriyukiK-1qbit
Copy link
Contributor Author

Hi!
try/catch is removed as requested.

@BoxiLi BoxiLi merged commit 6a2977e into qutip:master Oct 8, 2023
12 checks passed
@BoxiLi
Copy link
Member

BoxiLi commented Oct 8, 2023

@NoriyukiK-1qbit Thank you!

@NoriyukiK-1qbit NoriyukiK-1qbit deleted the NoriyukiK-1qbit-patch-1 branch October 10, 2023 16:04
@BoxiLi BoxiLi added this to the qutip-qip-0.3.1 milestone Nov 4, 2023
BoxiLi pushed a commit to BoxiLi/qutip-qip that referenced this pull request Apr 20, 2024
@NoriyukiK-1qbit @BoxiLi
Remove comments after meaningful statements in QASM reader (qutip#218)
b85b379 
* QASMBench has comments after instructions

QASMBench has lines that have comments after instructions, and those lines cause errors.
This fix removes such comments.
@BoxiLi BoxiLi mentioned this pull request Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxiLi BoxiLi BoxiLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
qutip-qip-0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@NoriyukiK-1qbit @BoxiLi