-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RZX gate to the SCQubits model #245
Conversation
BoxiLi
commented
Aug 14, 2024
•
edited
Loading
edited
- Add the RZX gate for the SCQubits. It was the building block for CNOT but is now separated to generate Hamiltonian simulation more conveniently.
- Fix a bug in the gate decomposition, if the gate is added as a native gate, the resolve function lets it pass without an error.
- Fix a bug in the compilation of the ZX Hamiltonian. The wrong hardware parameters were used for the compilation (mismatch in the qubit label.
It looks like quite a few small details changed here. Could you add tests? |
Yes! The test is on the way. This is for the example in the qutip paper ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests. Looks good. I left some questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there is still a doctest error, but otherwise the changes look good to me.
- Add the RZX gate for the SCQubits. It was the building block for CNOT but is now separated to generate Hamiltonian simulation more conveniently. - Fix a bug in the gate decomposition, if the gate is added as a native gate, the resolve function lets it pass without an error. - Fix a bug in the compilation of the ZX Hamiltonian. The wrong hardware parameters were used for the compilation (mismatch in the qubit label.
- Add the RZX gate for the SCQubits. It was the building block for CNOT but is now separated to generate Hamiltonian simulation more conveniently. - Fix a bug in the gate decomposition, if the gate is added as a native gate, the resolve function lets it pass without an error. - Fix a bug in the compilation of the ZX Hamiltonian. The wrong hardware parameters were used for the compilation (mismatch in the qubit label.
# Version 0.3.2 Improvements ------------ - Add RZX gate to the SCQubits model. Fix bugs on the ZX strength. (#245) - Compile the documentation using qutip v5 (#246) Bug Fixes --------- - Add phi parameter to expand_operator call. (#237, issue raised by Neill Lambert) - Fix the warning on MacOS. (#240) - Fix a bug in :class:`~.QubitCircuit.add_1q_gate`. (#250, issue raised by hatlabcz Chao Zhou)