Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in add_1q_gate #254

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix a bug in add_1q_gate #254

merged 2 commits into from
Oct 7, 2024

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Oct 5, 2024

@gadhvirushiraj

In your example in #253 you defined start but not end, that is a bit weird way of using it. I think it is better to use qubits= in that case. I write now an explicit error message.

Would you like to review the changes I made?

Copy link
Contributor

@gadhvirushiraj gadhvirushiraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BoxiLi BoxiLi merged commit 36f38d0 into qutip:master Oct 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants