Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial mvp #1

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: initial mvp #1

wants to merge 11 commits into from

Conversation

MatanBobi
Copy link

@MatanBobi MatanBobi commented Feb 26, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Description

Initial implementation for qwik-testing-library

SHAI NOTES:

  1. Consider using the type JSXNode from Qwik instead of Ui
  2. The first test is passing but there is still an error in the logs we need to fix The first testing is failing inconsistently when using useScopedStyles, we should investigate that one.

apps/qwik-demo-app/src/components/header/header.spec.tsx Outdated Show resolved Hide resolved
baseElement = document.body;
}

if (!container) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll still need to use the wrapper here if passed, I removed it for now but will get back to it soon :)

@EggDice
Copy link

EggDice commented May 16, 2023

Can we merge this, it would be nice to use this! :)

@MatanBobi
Copy link
Author

Hi @EggDice!
This one needs a bit more polishing, I'll try to work on it this weekend :)

@EggDice
Copy link

EggDice commented May 19, 2023

I didn't want to make you work on weekends, I am happy to help, how can I? :)

cleanup by using the new cleanup function
@nx-cloud
Copy link

nx-cloud bot commented May 20, 2023

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit 148c9c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@MatanBobi
Copy link
Author

MatanBobi commented May 20, 2023

I didn't want to make you work on weekends, I am happy to help, how can I? :)

@EggDice, It's actually good that you've reminded me, I meant to get back to it :) It just took me more time than I thought it will.
If you want to help, I'll talk to @shairez a bit to see what we have left and we can split the tasks. Thanks for offering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants