Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkS3methods to ignore deprecated/defunct functions #76

Open
hturner opened this issue Nov 8, 2024 · 0 comments
Open

Update checkS3methods to ignore deprecated/defunct functions #76

hturner opened this issue Nov 8, 2024 · 0 comments
Labels
LatinR 2024 Misc Issues that cannot be classified otherwise needs patch Implement the agreed fix and prepare a patch for review R Issue should require knowledge of R only

Comments

@hturner
Copy link
Member

hturner commented Nov 8, 2024

This task is to update tools::checkS3methods(), so that ignores functions where there is a call to .Deprecated() or .Defunct() in the body of a function.

This will enable a more elegant approach to fixing packages that have functions that look like S3 methods, as discussed on the CRAN Cookbook repo. This approach has the support of Kurt Hornik from the CRAN team.

tools::checkS3methods() is a pure R function, but it is a long function! So part of the task will be working through the code to understand how it could be adapted to only check functions that are not deprecated or defunct, then working on the code to implement the change.

@hturner hturner added needs patch Implement the agreed fix and prepare a patch for review Misc Issues that cannot be classified otherwise LatinR 2024 R Issue should require knowledge of R only labels Nov 8, 2024
@hturner hturner changed the title Update checkS3methods to ignore depracated/defunct functions Update checkS3methods to ignore deprecated/defunct functions Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LatinR 2024 Misc Issues that cannot be classified otherwise needs patch Implement the agreed fix and prepare a patch for review R Issue should require knowledge of R only
Projects
None yet
Development

No branches or pull requests

1 participant