Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should use devtools::build() and not rcmdcheck::rcmdcheck() to build packages #17

Open
GegznaV opened this issue Aug 20, 2020 · 1 comment

Comments

@GegznaV
Copy link
Member

GegznaV commented Aug 20, 2020

Why do we need rcmdcheck::rcmdcheck() while devtools::build() is sufficient. A full R-CMD check is performed in a separate workflow and devtools::build() is faster. What is more, it is straightforward to make binary packages with this function by using additional argument: devtools::build(binary = TRUE).

@bryanhanson
Copy link
Collaborator

If it is better make the change. The original version was cobbled together from several sources and since it worked not optimization was considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants