-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning to paginated request that was performed by req_perform()
and not paginate_req_perform()
#336
Comments
I see that this was already suggested by @jonthegeek with the below reply
Originally posted by @mgirlich in #279 (comment) |
I agree that it would be nice to help the user here a little more.
I'm not convinced integrating Some ideas what we could do if we add a warning to
@hadley Do you have any good ideas? |
None of the options seem particularly appealing to me, so I'd prefer to stick to the status quo until we come up with something better. |
Now that we have the |
I was scratching my head for a while wondering why pagination wasn't working until I realized I had used
req_perform()
and notpaginate_req_perform()
.A warning to a paginated request performed via
req_perform()
might be appropriate to signal that the pagination was ignored. Alternatively, is it possible to somehow integrate pagination intoreq_perform()
and obviate the need forpaginate_req_perform()
?The text was updated successfully, but these errors were encountered: