You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Probably because of the changes in 2d28e26 where we no longer call unloadNamespace(). So now we should call .onUnload() if present, and similarly handle the onUnload hook.
The text was updated successfully, but these errors were encountered:
hmm, one problem I can see with this is that we try to preserve stale namespaces in a working state since it's so easy to run into dangling references, for example via an imports env populated before a load_all() call.
So it depends on what conventions should apply to the unload hook. Is it UB to call into a namespace that has run this hook, or should the package gracefully handle this situation?
Probably because of the changes in 2d28e26 where we no longer call
unloadNamespace()
. So now we should call.onUnload()
if present, and similarly handle theonUnload
hook.The text was updated successfully, but these errors were encountered: