Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify clean-filter parameter equality check #170

Open
blester125 opened this issue Jan 30, 2023 · 0 comments
Open

Simplify clean-filter parameter equality check #170

blester125 opened this issue Jan 30, 2023 · 0 comments

Comments

@blester125
Copy link
Collaborator

The equality check in the clean filter is pretty complex and in-line.

We should abstract it into a testable function, and maybe roll some of it (the initial lsh based check before loading the second parameter) into the __eq__ magic method of the parameter method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant