You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Error type is only used in runtime via tests, and the fact that a primitives crate is referring to pop api on line 16 makes it seem off.
I think the tests that use this error should probably live in pop-api/integration-tests, especially as it already takes a dev-dependency on the runtime. Then this error should only need to be defined in the pop-api crate, where it probably belongs as it is a contract-side only representation of the errors which exist in the runtime.
If a type isnt being used by both a contract AND the runtime, it probably doesnt need to be in this crate.
The text was updated successfully, but these errors were encountered:
Should also be checked in terms of runtime size, as you might effectively be compiling stuff into the runtime which is unnecessary, just for the convenience.
Daanvdplas
changed the title
refactor: define types used both in pop api as in chain extension in primitives
refactor: Error from primitives to contract library
Jul 24, 2024
The Error type is only used in runtime via tests, and the fact that a primitives crate is referring to pop api on line 16 makes it seem off.
I think the tests that use this error should probably live in pop-api/integration-tests, especially as it already takes a dev-dependency on the runtime. Then this error should only need to be defined in the pop-api crate, where it probably belongs as it is a contract-side only representation of the errors which exist in the runtime.
If a type isnt being used by both a contract AND the runtime, it probably doesnt need to be in this crate.
The text was updated successfully, but these errors were encountered: