Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This extenion will hang the vscode in the cluster-api repo #66

Open
heww opened this issue Oct 8, 2023 · 8 comments
Open

This extenion will hang the vscode in the cluster-api repo #66

heww opened this issue Oct 8, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@heww
Copy link

heww commented Oct 8, 2023

Open https://github.com/kubernetes-sigs/cluster-api repo with this extension, then try Go to Definition like the following video, the vscode will be hanging with this extension enabled.

video.mp4
@r3inbowari
Copy link
Owner

Hi, @heww, How does it work on local host? This problem may be reproduced on ssh.

@heww
Copy link
Author

heww commented Oct 9, 2023

This problem also happens on the local host.
In the beginning, I think the problem is from the gopls because it also happens on the local host. But then I try the cluster-api repo with Lapce and gopls, everything works well. So I use the Start Extension Bisect of vscode and find the problem is gone after disabling this extension.

@r3inbowari
Copy link
Owner

What can you see in Help>DevTools, Have you tried to disable auto reveal.

@heww
Copy link
Author

heww commented Oct 10, 2023

Here is the message from the DevTools when the vscode is hanging on local host.

Extension host (LocalProcess) terminated unexpectedly. Code: 6, Signal: unknown

<--- Last few GCs --->
[234
32:0x12400870000]   127191 ms: Scavenge (reduce) 3792.0 (3921.0) -> 3791.6 (3921.2) MB, 
3.00 / 0.00 ms  (average mu = 0.372, current mu = 0.361) allocation failure; 
[234
32:0x12400870000]   127196 ms: Scavenge (reduce) 3792.3 (3921.2) -> 3791.9 (3921.5) MB, 
3.96 / 0.00 ms  (average mu = 0.372, current mu = 0.361) allocation failure; 
[234
32:0x12400870000]   127201 ms: Scavenge (reduce) 3792.7 (3921.5) -> 3792.3 (3921.7) MB, 3.00 / 0.00 ms  (average mu = 0.372, current mu = 0.361) allocation failure; 
<--- JS stacktrace --->
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x10df6c778 node::Buffer::New(v8::Isolate*, char*, unsigned long) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 2: 0x10df6c9b8 node::OnFatalError(char const*, char const*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 3: 0x108ede738 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 4: 0x108ede6c0 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 5: 0x109098918 v8::internal::Heap::FinalizeIncrementalMarkingAtomically(v8::internal::GarbageCollectionReason) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 6: 0x10909c780 v8::internal::Heap::EnsureWasmCanonicalRttsSize(int) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 7: 0x109098c58 v8::internal::Heap::stack() [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 8: 0x10909716c v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 9: 0x1090969d8 v8::internal::Heap::MonotonicallyIncreasingTimeInMs() const [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
10: 0x109034d54 v8::internal::StackGuard::HandleInterrupts() [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
11: 0x1094a61cc v8::internal::Runtime::GetInternalProperties(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
12: 0x157edb618
13: 0x157f50f40
14: 0x150260b68
15: 0x1504a70b0
16: 0x150874db4
17: 0x157f3b210
18: 0x157e49f08
19: 0x15087525c
20: 0x157f3cc98
21: 0x157e74a24
22: 0x157e4aa38
23: 0x109004ba4 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
24: 0x109005398 v8::internal::Execution::TryCallScript(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSFunction>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::FixedArray>, v8::internal::Execution::MessageHandling, v8::internal::MaybeHandle<v8::internal::Object>*, bool) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
25: 0x109005504 v8::internal::Execution::TryCall(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*, v8::internal::Execution::MessageHandling, v8::internal::MaybeHandle<v8::internal::Object>*, bool) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
26: 0x109033854 v8::internal::MicrotaskQueue::get(long) const [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
27: 0x10dec7fa8 node::CallbackScope::~CallbackScope() [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
28: 0x10dec7c70 node::CallbackScope::~CallbackScope() [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
29: 0x108167c1c v8::CodeEvent::GetComment() [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
30: 0x10a9a8478 node::GetMultiIsolatePlatform(node::IsolateData*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
31: 0x10a9bbe18 node::GetMultiIsolatePlatform(node::IsolateData*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
32: 0x10a960690 node::GetMultiIsolatePlatform(node::IsolateData*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
33: 0x10a9bc9d0 node::GetMultiIsolatePlatform(node::IsolateData*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
34: 0x10a983e58 node::GetMultiIsolatePlatform(node::IsolateData*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
35: 0x10a71647c node::GetMultiIsolatePlatform(node::IsolateData*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
36: 0x108338fdc v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
37: 0x108339d3c v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
38: 0x108338600 v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
39: 0x10833882c v8::internal::compiler::BasicBlock::set_loop_header(v8::internal::compiler::BasicBlock*) [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
40: 0x10806d248 ElectronMain [/Applications/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
41: 0x10018cc10  [/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Plugin).app/Contents/MacOS/Code Helper (Plugin)]
42: 0x19aaaff28 start [/usr/lib/dyld]

After disabling the auto reveal, the problem is gone.

@r3inbowari r3inbowari added the bug Something isn't working label Oct 10, 2023
@r3inbowari
Copy link
Owner

r3inbowari commented Oct 10, 2023

image
Can you load these modules?

GIF 2023-10-11 0-10-36
Version: 1.82.2 (system setup)
Commit: abd2f3db4bdb28f9e95536dfa84d8479f1eb312d
Date: 2023-09-14T05:55:25.390Z
Electron: 25.8.1
ElectronBuildId: 23779380
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22621
I connected to the repo by SSH, but it work.

@r3inbowari
Copy link
Owner

Related to #50

@heww
Copy link
Author

heww commented Oct 11, 2023

Yes, I can load these modules.

The problem is gone after these modules are loaded in this extension even gomod.autoReveal is enabled.

@r3inbowari
Copy link
Owner

Record1.mov

I used a mac for testing, but it still can't reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants