Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indistinguishable text when previewing CWL under a dark color theme #91

Closed
nanxstats opened this issue Apr 25, 2020 · 1 comment
Closed
Labels
bug Something isn't working
Milestone

Comments

@nanxstats
Copy link

Node names are indistinguishable when previewing the CWL using a dark theme:

Screen Shot 2020-04-25 at 2 15 23 PM

To resolve this, might want to consider either force the preview panel to have a light background, like one would do in LaTeX previewers, or, determine the theme is light or dark and apply font colors accordingly (not sure if the current vscode API supports getting this though)

@ghost
Copy link

ghost commented Apr 27, 2020

Thanks for reporting this @nanxstats . I would imagine the best solution would be to detect the theme and supply two color sets depending on the theme. There are indications that this may be impossible: microsoft/vscode#46940

The best short term solution might be to pin the preview background color.

@ghost ghost self-assigned this Apr 27, 2020
@ghost ghost added the bug Something isn't working label Apr 27, 2020
@ghost ghost modified the milestones: No scheduled deadline, 2020.06.30 Apr 27, 2020
@ghost ghost closed this as completed in ec8068d Jun 3, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant