Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing version tags or releases #80

Open
johnctitus opened this issue Jul 6, 2018 · 1 comment
Open

Implementing version tags or releases #80

johnctitus opened this issue Jul 6, 2018 · 1 comment

Comments

@johnctitus
Copy link
Contributor

We ran into an issue when #79 was merged, as troposphere 2.3.1 has a bug in the EC2 CreditSpecification property that caused our templates to fail to build. We were able to pin to the previous commit of jetstream to get back to a lower troposphere version. It did however raise the idea of version tags.

It would be really nice to have versions or releases for this repo, to make pinning to the desired point a little easier and prettier.

@cwgem
Copy link
Contributor

cwgem commented Feb 7, 2019

While #89 plus some manual commands gave us this for now, there should be a CircleCI workflow around this. When master gets merged, a specific workflow should probably do the following:

  • Look for specific wording in the commit message to indicate a release
  • If that exists:
    • Tag the current SHA commit hash (using the Circle environment variable)
    • Push the tag to origin
    • Phase 2: Push a new release to pip so we can have easy installs without relying on git pulldowns

Note that this will most likely depend on getting the Python 3 work sorted out, as pip will deprecate Python 2.7 in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants