Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails for Collections? #778

Closed
m-mohr opened this issue Apr 16, 2020 · 1 comment · Fixed by #800
Closed

Thumbnails for Collections? #778

m-mohr opened this issue Apr 16, 2020 · 1 comment · Fixed by #800
Assignees
Milestone

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 16, 2020

Anyone has a good idea how we could incorporate thumbnails for collections? We have them for items, but we have some cases where we want to directly give some examples for collections.

Two way I could see here:

  1. Add a link to a thumbnail with rel type preview and image type image/jpeg (or gif/png). Currently clients don't recognize this so I'd propose to add it to the Collection Relation Types.
    Pro: This is possible without a real spec change.
    Con: It's different from how items do previews.
  2. Use the asset extension and add a href. This is also how we try to incorporate collection-level assets in Data Cube Extension: Variables and more #713. Based on this, define thumbnails as in the item spec.
    Pro: Is aligned with Item spec.
    Con: Needs a spec change (asset extension) and basically introduces collection-level assets.

Other options? Opinions?

@matthewhanson
Copy link
Collaborator

I think if it were only for thumbnails then having it as a link would be good, but if we have a use for other collection level assets, such as using the Zarr format, then thumbnails should be specified as assets to be like collections.

@m-mohr m-mohr self-assigned this Apr 28, 2020
@m-mohr m-mohr added this to the 1.0.0-beta1 milestone Apr 28, 2020
m-mohr added a commit that referenced this issue May 5, 2020
@m-mohr m-mohr mentioned this issue May 5, 2020
4 tasks
m-mohr added a commit that referenced this issue May 5, 2020
@m-mohr m-mohr linked a pull request May 5, 2020 that will close this issue
4 tasks
@m-mohr m-mohr closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants