Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Schemas don't allow "shortcuts" for core extensions any longer #1121

Merged
merged 2 commits into from
May 4, 2021
Merged

JSON Schemas don't allow "shortcuts" for core extensions any longer #1121

merged 2 commits into from
May 4, 2021

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented May 4, 2021

Related Issue(s): None

Proposed Changes:

  1. JSON Schemas don't allow "shortcuts" for core extensions any longer

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr added this to the 1.0.0-rc.4 milestone May 4, 2021
@m-mohr m-mohr mentioned this pull request May 4, 2021
Merged
4 tasks
emmanuelmathot
emmanuelmathot approved these changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested schemas of this PR branch in DotNetStac. It now returns an schema validation error when using simple string like "shortcuts" in stac_extensions. Good to go.

@m-mohr m-mohr merged commit 9fb18e7 into dev May 4, 2021
@m-mohr m-mohr deleted the remove-core-ext-schema branch May 4, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot approved these changes

@lossyrob lossyrob lossyrob approved these changes

@cholmes cholmes Awaiting requested review from cholmes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

@jbants jbants Awaiting requested review from jbants

Assignees
No one assigned
Labels
json schema
Projects
None yet
Milestone
1.0.0-rc.4
Development

Successfully merging this pull request may close these issues.
3 participants
@m-mohr @emmanuelmathot @lossyrob