Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added best practice to include title, updated examples #1133

Merged
merged 1 commit into from
May 25, 2021
Merged

added best practice to include title, updated examples #1133

merged 1 commit into from
May 25, 2021

Conversation

cholmes
Copy link
Contributor

@cholmes cholmes commented May 24, 2021

Related Issue(s): #1132

Proposed Changes:

  1. Added small best practice section on links
  2. updated examples

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • a CHANGELOG entry is not required.

@cholmes cholmes mentioned this pull request May 24, 2021
Closed
@m-mohr m-mohr linked an issue May 25, 2021 that may be closed by this pull request
Recommendation to add titles to links? #1132
Closed
@cholmes cholmes merged commit c197acb into dev May 25, 2021
@cholmes cholmes deleted the title-rec branch May 25, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr approved these changes

@jbants jbants jbants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommendation to add titles to links?
3 participants
@cholmes @m-mohr @jbants