Update ci config #334
Merged
Update ci config #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2018 22:42
|
Thanks! I have a question: You said, it "only validates against stac_spec release versions (github tags) right now". So if we merge that to dev and want to make a PR that changes JSON schemas and examples, wouldn't this fail in the CI and thus block us from changing anything in JSON schemas in dev at all? |
|
You are correct, It would currently fail on new schema changes to dev. Since there won't be (I don't think) any breaking changes between the json schemas from rc2, I didn't want to hold up the release of 0.6.0. |
matthewhanson
requested review from
m-mohr,
scisco,
matthewhanson and
cholmes
matthewhanson
approved these changes
Oct 30, 2018
|
This looks good to me for now, since as @jbants points out it will only fail on schema changes. |
cholmes
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the circleci config to use the python stac_validator.
This starts to work on #199 as it supports pulling in remote references and can be used locally to validate a STAC. The validator only validates against stac_spec release versions (github tags) right now. An issue has been created to support validating against stac_spec branches and local schemas as well. This would support different CI configurations.