Align summaries with JSON Schema vocabulary #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` and `max` to `maximum` to align with JSON Schema.
m-mohr
force-pushed
the
json-schema-for-sumamries
branch
from
7a67089
to
07a14e8
Compare
cholmes
approved these changes
Feb 5, 2021
matthewhanson
approved these changes
Feb 8, 2021
cholmes
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): None
Proposed Changes:
It recently came up that it could be useful to align the stats object with JSON Schema so that, if you want, can make this work and extended by JSON Schema vocabulary. We won't add additional fields here or promote anything liek that in the spec, but it leaves the option to implementers to use it.
PR Checklist: