Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from colorful to rich #439

Open
fliiiix opened this issue Oct 7, 2022 · 5 comments
Open

Switch from colorful to rich #439

fliiiix opened this issue Oct 7, 2022 · 5 comments
Labels
blocked enhancement feature request
Milestone
radish drop legac...

Comments

@fliiiix
Copy link
Member

fliiiix commented Oct 7, 2022

We should consider switching from colorful to https://github.com/Textualize/rich which is better maintain
@fliiiix
Copy link
Member Author

fliiiix commented Oct 7, 2022

Need to drop 3.5 support first.

@inquisitev
Copy link
Contributor

Need to drop 3.5 support first.

when is a good time to drop 3.5 support?

@fliiiix
Copy link
Member Author

fliiiix commented Oct 6, 2023

A good time would have been 3-4 years ago 😅 but we still use it on debian stretch which ships with python3.5 😭

I can check what the timeline is to migrate away from stretch, i assume you would be interested in tackling this issue?

@inquisitev
Copy link
Contributor

Sure I'd take a swing

@inquisitev
Copy link
Contributor

oh boy this is going to break every single integration test 😆

@inquisitev inquisitev mentioned this issue Oct 8, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked enhancement feature request
Projects
None yet
Milestone
radish drop legacy (Debian Stretch)
Development

Successfully merging a pull request may close this issue.

Migrate from Colorful to Rich inquisitev/radish
2 participants
@fliiiix @inquisitev