[ABW-3562] Third party deposits UI updates #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
added
the
DO NOT MERGE
Comment on lines
117
to
118
| "revision" : "5b6d946221837aa6bed3b5ff725eb5fe4f844c6c", | ||
| "version" : "1.0.31" | ||
| "revision" : "b6342f791da0b29ca639b37abccdad04465501a1", | ||
| "version" : "1.0.29" |
| var textStyle: TextStyle { | ||
| switch viewState.kind { | ||
| case .info, .error, .warning: | ||
| .body2HighImportance |
There was a problem hiding this comment.
Based on Zeplin it looks like there are situations where info and error should be body2Regular 🤔
There was a problem hiding this comment.
can you share those? I would still take care of it (after confirming with Aftab that we want them differently) on the other branch that makes more changes to Hint though (it is branched off from this one).
| } | ||
| .padding([.horizontal, .bottom], .medium1) | ||
| addAssetButton(viewStore) |
danvleju-rdx
approved these changes
Jul 29, 2024
GhenadieVP
removed
the
DO NOT MERGE
GhenadieVP
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3562
Description
Updates the Third-party deposits flow as well as:
PlainListRowto render any view as accessoryPlainListRowCore.Context.general: we will now always use.settings(except forToogleViewthat uses.toggle).ResourcesListView&PreferenceListViewto usePlainListRow, instead of implementing similar views themselves.Hintto allow.detail, which uses orange like.warningbut with smaller font and no icon.Before vs After
before.mov
after.mov