Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Installer strings in Inno Setup script #119

Closed
bovirus opened this issue Nov 6, 2023 · 1 comment
Closed

[BUG] Installer strings in Inno Setup script #119

bovirus opened this issue Nov 6, 2023 · 1 comment
Labels
bug Something isn't working triage Marks issues that were created with an issue template

Comments

@bovirus
Copy link
Contributor

bovirus commented Nov 6, 2023

Version Number

6.5.1

File

Installer (VolumeControl-Installer.exe)

Windows Version

Windows 10 22H2 64bit Italian

Actual Behaviour

Currently yuou changed the copyright string in

AppCopyright=Copyright © {#CurrentYear} {#AppPublisher}

"copyrighT" and "©" are synonims:
Copyright is already the field name of this descrition then the fulls string fieldname+description is

Copyright: Copyright © {#CurrentYear} {#AppPublisher}

Three times the copyright terms.

My idea is that the copyright message should be like before

AppCopyright=© {#StartYearCopyright}-{#CurrentYear} {#AppPublisher}

Thanks.

Expected Behaviour

Restroe original message

Reproduction Steps

No response

Log

No response

@bovirus bovirus added bug Something isn't working triage Marks issues that were created with an issue template labels Nov 6, 2023
@bovirus bovirus changed the title [BUG] Instalelr strings in Inno Setup [BUG] Installer strings in Inno Setup script Nov 6, 2023
@radj307 radj307 closed this as completed in 1f5c404 Nov 8, 2023
@radj307
Copy link
Owner

radj307 commented Nov 8, 2023

Readded date range in 1f5c404

The message now reads Copyright © 2022-2023 radj307, which will be the final copyright notice string.
The property being named "Copyright" does not guarantee that its contents are actually a copyright notice; some applications put the license name, copyleft notice, etc. there instead. This can be interpreted as ambiguity.
Putting both "Copyright" and "©" makes it impossible to misinterpret one or the other, and brings it in line with my other projects & the recommended format in Canada (where I live) & the USA.

Overall, the point of a copyright notice is not to look nice, it's to state that a copyright exists in the least ambiguous, most universally-understandable way possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Marks issues that were created with an issue template
Projects
None yet
Development

No branches or pull requests

2 participants