Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As tech lead, I want local configurations to use nginx #2032

Closed
8 tasks
andrew-jameson opened this issue Aug 5, 2022 · 2 comments
Closed
8 tasks

As tech lead, I want local configurations to use nginx #2032

andrew-jameson opened this issue Aug 5, 2022 · 2 comments
Labels
dev devops DX Developer Experience Refined Ticket has been refined at the backlog refinement techdebt

Comments

@andrew-jameson
Copy link
Collaborator

andrew-jameson commented Aug 5, 2022

Description:
As we uncovered in #1945, our development docker images do not use nginx for the frontend. We should use nginx so that we can more closely mimic production in our development processes.

Acceptance Criteria:

  • Using our dev aliases, tdrs-start will spin up the frontend with nginx
  • The nginx configurations for local and prod are functionally equivalent
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:

  • Investigate use of nginx docker base
  • Set docker-compose configurations to ensure reactjs and nginx are spun up seamlessly
  • Match local nginx cfg to production nginx cfg
  • Run Testing Checklist and confirm all tests pass

Notes:

Supporting Documentation:

Open Questions:

  • Should we just reactjs run inside an nginx docker image similar to our buildpack architecture? While we would have to run through some setup steps, this feels like the 'best' solution but I'm unsure of the lift to get that work done and how that might impact scope.
@andrew-jameson
Copy link
Collaborator Author

This will be just for local dev nginx configs and use of hosts files and/or domains will be split off into another ticket.

@andrew-jameson andrew-jameson changed the title [WIP] As tech lead, I want our development environments to more closely match production environments As tech lead, I want local configurations to use nginx Aug 16, 2022
@andrew-jameson andrew-jameson removed their assignment Aug 16, 2022
@stevenino stevenino added the Refined Ticket has been refined at the backlog refinement label Sep 27, 2022
@andrew-jameson
Copy link
Collaborator Author

Per dev meeting 10/27, this is now obsolete. Finished in #1544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev devops DX Developer Experience Refined Ticket has been refined at the backlog refinement techdebt
Projects
None yet
Development

No branches or pull requests

3 participants