Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as many iterations into PFS imbalance fee calculation as we use in the Raiden client #563

Closed
Dominik1999 opened this issue Oct 2, 2019 · 1 comment · Fixed by #565
Assignees
Labels
PFS 🚀 Related to the Pathfinding Service
Milestone

Comments

@Dominik1999
Copy link
Contributor

Currently, the Raiden client iterates the imbalance fee calculation one time whereas the corresponding calculation in the pfs does not iterate.

We need to adjust the pfs fee calculation to the client calculation.

See here for reference https://docs.google.com/spreadsheets/d/1nHVCOhMcrM-L8brJj_C_Qb0Paws1qwozcNHU3VFcWEY/edit#gid=1257400215

@palango palango added the PFS 🚀 Related to the Pathfinding Service label Oct 2, 2019
@palango palango added this to the Alderaan milestone Oct 2, 2019
@palango
Copy link
Contributor

palango commented Oct 2, 2019

There is some code for this in raiden-network/raiden#5024, this needs to be copied to the PFS or be used from the raiden codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PFS 🚀 Related to the Pathfinding Service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants