Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More error_details on DepositTooLow #761

Merged

Conversation

karlb
Copy link
Contributor

@karlb karlb commented Mar 27, 2020

As requested by @hackaugusto.

@auto-assign auto-assign bot requested a review from palango March 27, 2020 09:47
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #761 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          35       35           
  Lines        2546     2546           
  Branches      325      325           
=======================================
  Hits         2295     2295           
  Misses        190      190           
  Partials       61       61           
Impacted Files Coverage Δ
src/pathfinding_service/api.py 95.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4d737...dfb0370. Read the comment docs.

Copy link
Contributor

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@palango palango merged commit f4bcb9c into raiden-network:master Mar 27, 2020
@karlb karlb deleted the more-details-on-deposit-too-low branch March 27, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants