Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MS DEFAULT_MIN_REWARD to Raiden's default #773

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

karlb
Copy link
Contributor

@karlb karlb commented Apr 27, 2020

We don't have a communication channel to establish a good reward during
runtime, so using the same fixed value is best in the meantime.
This also prevents MS operators from accidentally not demanding a
reward, which is a bad idea since they have to pay transaction fees.

We don't have a communication channel to establish a good reward during
runtime, so using the same fixed value is best in the meantime.
This also prevents MS operators from accidentally not demanding a
reward, which is a bad idea since they have to pay transaction fees.
@auto-assign auto-assign bot requested a review from palango April 27, 2020 11:07
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #773 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   90.54%   90.46%   -0.08%     
==========================================
  Files          35       35              
  Lines        2590     2591       +1     
  Branches      329      329              
==========================================
- Hits         2345     2344       -1     
- Misses        178      180       +2     
  Partials       67       67              
Impacted Files Coverage Δ
src/monitoring_service/cli.py 83.78% <100.00%> (ø)
src/monitoring_service/constants.py 100.00% <100.00%> (ø)
src/pathfinding_service/api.py 94.86% <0.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291ef80...bd441b1. Read the comment docs.

@karlb karlb requested a review from Dominik1999 April 27, 2020 11:31
Copy link
Contributor

@Dominik1999 Dominik1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@karlb karlb merged commit 790681d into raiden-network:master Apr 28, 2020
@karlb karlb deleted the default-reward branch April 28, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants