Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.14.1: Disable thread logging, reset resolver settings, pin raiden #937

Merged
merged 5 commits into from
Feb 26, 2021

Conversation

konradkonrad
Copy link
Contributor

@konradkonrad konradkonrad commented Feb 25, 2021

This sets up the version for a new release 0.14.1

Patch changes:

  • This fixes an issue when setting up sentry, where the gevent threading module monkeypatching wasn't completed, while the sentry setup already generated log events with thread logging enabled.

  • This also removes a patch from the DNS resolver, that lead to problems when trying to resolve addresses from a VPN NS from within docker.

  • Furthermore, the raiden dependency, formerly linked to the develop at github, is now linked to a specific commit. This is done to remove version ambiguity for the next release of raiden-services.

@auto-assign auto-assign bot requested a review from karlb February 25, 2021 14:43
This avoids ambiguity for the upcoming release of .
@konradkonrad konradkonrad force-pushed the disable_thread_logging branch from b23f0ea to bd7d9e8 Compare February 25, 2021 15:51
@konradkonrad konradkonrad changed the title Disable thread logging, reset resolver settings Disable thread logging, reset resolver settings, pin raiden Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #937 (aeacad1) into master (a1fa5d9) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
- Coverage   89.61%   89.58%   -0.04%     
==========================================
  Files          41       41              
  Lines        3159     3159              
  Branches      398      398              
==========================================
- Hits         2831     2830       -1     
- Misses        237      238       +1     
  Partials       91       91              
Impacted Files Coverage Δ
src/raiden_libs/cli.py 79.83% <0.00%> (-0.65%) ⬇️
src/monitoring_service/cli.py 83.05% <100.00%> (-0.29%) ⬇️
src/pathfinding_service/cli.py 90.32% <100.00%> (-0.16%) ⬇️
src/raiden_libs/logging.py 89.47% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fa5d9...aeacad1. Read the comment docs.

@konradkonrad konradkonrad changed the title Disable thread logging, reset resolver settings, pin raiden Release 0.14.1: Disable thread logging, reset resolver settings, pin raiden Feb 25, 2021
Copy link
Contributor

@karlb karlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if problems with the thread resolver reappear somewhere.

@karlb karlb merged commit 883c73b into master Feb 26, 2021
@palango palango deleted the disable_thread_logging branch October 4, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants