Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remove ANTs C++ binaries to reduce bloatware #45

Open
andreped opened this issue Sep 22, 2023 · 3 comments
Open

Feature: Remove ANTs C++ binaries to reduce bloatware #45

andreped opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@andreped
Copy link
Member

Is your feature request related to a problem? Please describe.
As we are not using the C++ binaries, and it does not even work on Windows and the PyANTs works fine, I say that we should just remove the ANTs C++ binaries all together.

This will greatly reduce the installer size, which was increased by about 3x in size, just to do the ANTs binaries alone.

@andreped andreped added the enhancement New feature or request label Sep 22, 2023
@andreped
Copy link
Member Author

andreped commented Sep 25, 2023

Also note that CIs take A LOT longer to run due to the generated installers being a lot larger, as uploading these artifacts takes an extremely amount of time.

Removing the binaries, also removed the "Free up GitHub Actions Ubuntu Runner Disk Space step (see here) which surprisingly takes almost 6 (!) minutes to perform.

@andreped
Copy link
Member Author

andreped commented Sep 25, 2023

Overall it seems like build times on Ubuntu increases by 20 minutes (30 -> 50 minutes) with having the C++ binaries. But this also affects the other CIs for respective OS and CPU.

@dbouget
Copy link
Collaborator

dbouget commented Sep 27, 2023

Better to use the C++ ANTs as it's updated more frequently than the Python package, and the Python package does not run on the mac M1.
The issue with the c++ ANTs in Windows is that it is not possible to subprocess a bash script, would need to rewrite in Raidionics the content to just call the .exe in the end.

@dbouget dbouget self-assigned this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants