Skip to content

Commit

Permalink
Drop support to Ruby < 2.6
Browse files Browse the repository at this point in the history
Now that Bundler doesn't support old rubies anymore, we can do the same.
  • Loading branch information
rafaelfranca committed May 11, 2023
1 parent 6a5594f commit 0e2346f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
ruby: ['2.0', 2.1, 2.2, 2.3, 2.4, 2.5, 2.6, 2.7, '3.0', 3.1, 3.2, head]
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', 'head']

This comment has been minimized.

Copy link
@mfittko

mfittko Nov 7, 2023

can we revert this? you broke our chef server setup as we need 2.3 💩

This comment has been minimized.

Copy link
@mfittko

mfittko Nov 7, 2023

for reference, our (outdated) chef version does not lock thor in its Gemfile.lock:
https://github.com/chef/chef/blob/v12.22.5/Gemfile.lock#L304

This comment has been minimized.

Copy link
@mfittko

mfittko Nov 7, 2023

okay, nvm, we found a way to install the old thor version in our bootstrap script using the embedded chef ruby/rubygems (for anyone interested)

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
inherit_from: .rubocop_todo.yml

AllCops:
TargetRubyVersion: 2.0
TargetRubyVersion: 2.6
DisabledByDefault: true
Exclude:
- spec/sandbox/**/*
Expand Down
2 changes: 1 addition & 1 deletion thor.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
"rubygems_mfa_required" => "true",
}

spec.required_ruby_version = ">= 2.0.0"
spec.required_ruby_version = ">= 2.6.0"
spec.required_rubygems_version = ">= 1.3.5"

spec.files = %w(.document thor.gemspec) + Dir["*.md", "bin/*", "lib/**/*.rb"]
Expand Down

0 comments on commit 0e2346f

Please sign in to comment.