Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
readline
has issues under Windows, and those issues sometimes preventthor
from being used.For example, in our bundler Windows CI, we had to patch
rb-readline
to workaround some issuesbecause
rb-readline
(the defaultreadline
provider on Windows) couldn't be required. Moreover, we still get some issues when requiringrb-readline
likeSince in some situations the part of thor using
readline
(Thor::LineEditor
) is not required, for example, in most of CI situations. I thought it could be a good idea to lazily requirereadline
.Just to be clear, this is not a problem with
thor
at all, but since requiring unnecessary things lazily is usually a good thing, I figured we could do this.Also, an alternative version of this patch would be to autoload
Thor::LineEditor
, like