Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone for v4 release? #1713

Closed
bjankord opened this issue Sep 25, 2018 · 10 comments
Closed

Milestone for v4 release? #1713

bjankord opened this issue Sep 25, 2018 · 10 comments

Comments

@bjankord
Copy link

Might be helpful to add a milestone for the v4.0.0 release so people can get a sense of where things are at on the project, what all is still left to get in v4.0.0, etc.

@zernie
Copy link
Contributor

zernie commented Sep 26, 2018

Agreed, that might prompt some people (including myself) to work on the issues that need to be resolved before 4.0.

@gauravtiwari
Copy link
Member

Thanks @bjankord @zernie for the help.

I will go through the issues and put them under 4.0 label so we can work on it, thanks again. If you could help clean up the issues list that would be great too.

@gauravtiwari
Copy link
Member

Made a pre-release (with babel 7 support):

yarn add @rails/webpacker@next
bundle update webpacker

Any help regarding cleaning up issue list would be much appreciated.

@RiccardoMargiotta
Copy link

@gauravtiwari Thanks for adding the pre-release instructions and yarn bundle, it made it easy to try out the current pre.3 release.

A little feedback for you, I spent yesterday afternoon migrating my main project over to take advantage of Webpack 4 and Babel 7, and it's gone pretty smoothly.

A couple of quirks I came across not really relating to Webpacker, was that I initially forgot that the Babel preset react is now @babel/preset-react, and I needed to change the preset-env config to "modules": "commonjs" and "useBuiltIns": "usage". (That first issue was highlighted to me when I ran the babel-upgrade tool.)

Otherwise, I was able to remove a bunch of code to inline the manifest file, removed specific imports of babel-polyfill as it's now completely handled by preset-env, and I replaced my node modules chunk from the CommonsChunkPlugin with the new SplitChunks:

module.exports = {
  optimization: {
    splitChunks: {
      cacheGroups: {
        commons: {
          test: /[\\/]node_modules[\\/]/,
          name: 'vendor',
          chunks(chunk) {
            // exclude `server_rendering`
            return chunk.name !== 'server_rendering';
          }
        }
      }
    }
  }
};

It's working nicely, and with no changes to the main codebase, my JS bundles have been reduced by 15KB (195KB -> 180KB).

Thanks for all your hard work. 👍

@justin808
Copy link
Contributor

I just wrote an article on using the pre-release of v4 with React on Rails, including server-side-rendering and concurrent use of the webpack-dev-server.

Easy React Server Rendering with rails/webpacker v4 and React on Rails

I included a few github repo examples.

💥

image

@p0wl
Copy link
Contributor

p0wl commented Nov 14, 2018

Hey, any updates regarding the remaining issues for v4? If they were labeled or assigned to a milestone it would help me for sure.

Thanks for all your work @gauravtiwari, sooo looking forward to v4 (as we can get rid of lots of our customization/plugins)!

@gauravtiwari
Copy link
Member

Sorry about long silence everyone 🙏 I was away and just got back, will review the remaining issues and PRs. Please give me a few days to settle and make a final release (most probably coming Monday)

@gauravtiwari
Copy link
Member

Made a final PR here #1823

@gauravtiwari
Copy link
Member

Released an RC, please give it a test and if all's well will make a stable release this weekend.

@jfly
Copy link
Contributor

jfly commented Jan 3, 2019

Any update on that weekend release? No worries that it's taking longer than expected, just would like to get a sense of when the new release is expected to come out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants