-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warning for check_yarn_integrity seems not to happen? #2714
Comments
Additionally, the Update: #2715 |
Ah, this would have to be a call to the Webpacker logger instead of Kernel#warn. |
Taking that approach, I started to write a test for this.
I expected it to fail, but it passed. So, |
fixed by removing this webpacker/lib/webpacker/configuration.rb Line 58 in 63f59de
|
@rossta Hi Ross 👋 In #2518, you added this deprecation warning:
But I don't see it in my log.
My configuration:
Maybe
config.webpacker.check_yarn_integrity
is an old API, so old that it wasn't working anyway? I'm trying to trace the call tocheck_yarn_integrity=
using my debugger, but I'm unsure how the config gets from railties to webpacker.Is this worth spending time on? I just want other people to see this warning.
The text was updated successfully, but these errors were encountered: