Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alias to_h for to_hash #277

Merged
merged 5 commits into from
Jun 6, 2020
Merged

Added alias to_h for to_hash #277

merged 5 commits into from
Jun 6, 2020

Conversation

StoneGod
Copy link
Contributor

@StoneGod StoneGod commented Jun 2, 2020 •
edited by pkuczynski
Loading

Fixes #217

@pkuczynski pkuczynski added this to the 2.3.0 milestone Jun 2, 2020
@pkuczynski pkuczynski linked an issue Jun 2, 2020 that may be closed by this pull request
Config::Options: to_hash and to_h have different behaviour #217
Closed
@pkuczynski pkuczynski mentioned this pull request Jun 2, 2020
Merged
@pkuczynski pkuczynski merged commit 4b65ca6 into rubyconfig:master Jun 6, 2020
@pkuczynski pkuczynski modified the milestones: 2.3.0, 2.2.2 Dec 8, 2020
NickLaMuro added a commit to NickLaMuro/manageiq that referenced this pull request Dec 9, 2020
@NickLaMuro
[Gemfile] Lock the config gem
288fd13 
This had a recent change to it that broke our build:

rubyconfig/config#277

https://travis-ci.com/github/ManageIQ/manageiq-api/jobs/456702122#L1985-L1994 (master)
https://travis-ci.com/github/ManageIQ/manageiq-api/builds/207478687#L1995-L2004 (kasparov)
https://travis-ci.com/github/ManageIQ/manageiq-api/builds/207524405#L2113-L2122 (jansa)

So for now, lock the version to a known working version for us.
@NickLaMuro NickLaMuro mentioned this pull request Dec 9, 2020
Merged
@Fryguy
Copy link
Member

Fryguy commented Dec 9, 2020

@pkuczynski This PR seems to have broken backward compatibility - more details here: #217 (comment)

pkuczynski added a commit that referenced this pull request Dec 9, 2020
@pkuczynski
Revert "Added alias to_h for to_hash (#277)"
59285f1 
This reverts commit 4b65ca6
@pkuczynski pkuczynski mentioned this pull request Dec 9, 2020
Merged
pkuczynski added a commit that referenced this pull request Dec 9, 2020
@pkuczynski
Revert "Added alias to_h for to_hash (#277)" (#295)
3c4b77e 
This reverts commit 4b65ca6
@pkuczynski pkuczynski mentioned this pull request Dec 10, 2020
Merged
ippachi pushed a commit to ippachi/config-1 that referenced this pull request Oct 3, 2021
@StoneGod @ippachi
Added alias to_h for to_hash (rubyconfig#277)
bb1546d
ippachi pushed a commit to ippachi/config-1 that referenced this pull request Oct 3, 2021
@pkuczynski @ippachi
Revert "Added alias to_h for to_hash (rubyconfig#277)" (rubyconfig#295)
082a2e6 
This reverts commit 4b65ca6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

Config::Options: to_hash and to_h have different behaviour
3 participants
@StoneGod @Fryguy @pkuczynski