Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge_hash_arrays as an option to pass to DeepMerge #214

Merged
merged 6 commits into from
Jun 22, 2019

Conversation

wasik
Copy link
Contributor

@wasik wasik commented Jan 10, 2019

DeepMerge has an option to merge hashes within arrays. This exposes that through the Config configuration.

@pkuczynski
Copy link
Member

Looks good! Could you please update README, CHANGELOG and add a test for it?

@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@rubyconfig rubyconfig deleted a comment Jan 11, 2019
@pkuczynski pkuczynski requested review from rdubya and pkuczynski June 20, 2019 22:05
Copy link
Member

@pkuczynski pkuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. @rdubya what do you think?

@rubyconfig rubyconfig deleted a comment Jun 20, 2019
Copy link
Contributor

@rdubya rdubya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look ok, I don't know enough about the deep_merge gem to say much other than that

@pkuczynski pkuczynski merged commit b9284de into rubyconfig:master Jun 22, 2019
@pkuczynski
Copy link
Member

@wasik sorry for late merge...

@pkuczynski pkuczynski added this to the 2.0 milestone Jun 22, 2019
@wasik
Copy link
Contributor Author

wasik commented Jun 22, 2019

No problem; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants