Ignore .local files in test environment #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pyromaniac and @rdubya what do you think? Should we ignore local files in test env? |
|
Those truffleruby failures seem unrelated. |
rdubya
requested changes
Jul 8, 2019
|
Missing changelog entry, readme update, and codeclimate failures... |
|
Done. |
rdubya
approved these changes
Jul 11, 2019
pkuczynski
approved these changes
Jul 11, 2019
|
Looks good! Thanks! :) |
|
This gem needs a bit more love. @franzliedke maybe you would like to become a contributor? |
|
@pkuczynski Thanks for reaching out! I think I have to decline, though - busy enough keeping up with my own open-source projects, I'm afraid. 😕 Thanks for maintaining this and putting your work out there! |
|
Sure, no worries! :) I know how it feels to be overwhelmed with other projets :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without an option - was that requested or not? What should that look like?
Fixes #135.